Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update active-features.js show themes #2169

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Update active-features.js show themes #2169

merged 2 commits into from
Apr 9, 2024

Conversation

raszpl
Copy link
Contributor

@raszpl raszpl commented Apr 8, 2024 •
edited

fixes #2168
search #1935

@ImprovedTube
Copy link
Member

nice!

@ImprovedTube ImprovedTube merged commit 87aa7e4 into code-charity:master Apr 9, 2024
@raszpl raszpl deleted the patch-6 branch April 9, 2024 12:33
@raszpl
Copy link
Contributor Author

raszpl commented Apr 9, 2024

adding , 'label'], also lets search work on themes. So while previously searching for "sunset" returned nothing, now it properly returns sunset theme. Optimally it should also return results when searching for "theme", but I need to think some more on how to implement it elegantly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Selected Theme never shows in "My active features" list.
2 participants
@raszpl @ImprovedTube