Update styles.css Shorts Background

[raszpl]

#2320

[ImprovedTube]

yay!!

[ImprovedTube]

does removing these matter?

	case 'light':
		document.documentElement.removeAttribute('dark');
		document.querySelector('ytd-masthead')?.removeAttribute('dark');

[raszpl]

Removing dark shouldnt matter for the most part, there are still some missing CSS rules tho like loading placeholders for icons/thumbnails - those show up as black rectangles with dark cookie. Im too lazy to check what to override there.

I moved it down because if 'light' gets it there is no reason for all other themes not to get it. Still this would only matter if ImprovedTube.setTheme() was actually called during loading, currently its not. Im it should be merged with myColors() again.

[ImprovedTube]

then you didn't mean to remove them at case 'light' ?
Didnt find a reason for the function to run always.

when switching themes ambient mode from 'dark' might stay with 'light' or custom colors, which was fixed 1 year ago, so i'm fetching another line from the old file.

[ImprovedTube]

then you didn't mean to remove them at case 'light' ?
Didn't find a reason for the function to run always.

did you see/get, when switching themes ambient mode from 'dark' might stay with 'light' or custom colors (was fixed 1 year ago, so i'm fetching another line from the old file)

[raszpl]

then you didn't mean to remove them at case 'light' ?

nothing was removed, '// fall through' comment is there to remind people of that
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/switch#breaking_and_fall-through
Those line breaks inside Switch statement are there for a reason.

Didn't find a reason for the function to run always.

the reason is:

did you see/get, when switching themes ambient mode from 'dark' might stay with 'light' or custom colors (was fixed 1 year ago, so i'm fetching another line from the old file)

thats why you need to run myThemes(),. and since you need to run both themes and colors there is no point not combining them into one
I dont get why you feel hiding cinematics makes sense for some themes when we have explicit option for 'Ambient lighting'. No matter, which ones should it be disabled for? all except dark and black?

40b586e

youtube/js&css/web-accessible/www.youtube.com/themes.js

Line 104 in 40b586e

if(document.getElementById("cinematics") !== null)

#2042 (comment)

but you dont even need explicit comparison block there to begin with.

youtube/js&css/web-accessible/www.youtube.com/themes.js

Line 106 in 40b586e

document.getElementById("cinematics").style.display = 'none !important';}

never worked, cant set !important thru .style.display interface, only accepts a specific fixed list of parameters https://www.w3schools.com/jsref/prop_style_display.asp

to actually make !important stick you need either

document.getElementById("cinematics").setAttribute( 'style', 'display: none !important' );
document.getElementById("cinematics").style.setProperty("display", "none", "important");

Testing now you dont need !important there at all.

youtube/js&css/web-accessible/www.youtube.com/themes.js

Lines 105 to 106 in 40b586e

	{document.getElementById("cinematics").style.visibility = 'hidden';
	document.getElementById("cinematics").style.display = 'none !important';}

do you want display none or invisible? display:none and visibility:hidden are two distinctly different things

#2325