Add Jest Framework, JSLint, and Testing Workflow #2345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you! (didnt review yet.) BTW can we reduce the number of files in the root directory? (cosmetics) |
|
side-effect: "used by: 899 people"-box (not making sense for this project) |
|
Hello 👋 Is there any update on the reviewing part? |
ImprovedTube
added a commit
that referenced
this pull request
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request focuses on improving testing and code quality.
Changes
-New package.json file to add Jest and JSLint
-Added Jest Framework: Implemented Jest using npm. Jest is now configured to run tests located in the "tests" directory.
-Added JSLint as it was suggested as a development dependency.
-Added a GitHub Actions workflow file (js-lint-test.yml) to automate the process of running JSLint and Jest tests. This workflow showcases all the JSLint remarks and the testing results
Added 4 Initial Unit Tests for camelize function and events function (TRIGGER Chapter) in the core.js file. These tests are written using Jest and utilize mocking techniques, because I didn't want to export the extension object and make changes in the core.js
Created a jest.config.js file to improve the process.
Additional Notes:
All five tests have been successfully executed, confirming the reliability and effectiveness of the Jest in the core.js file.
I tried to keep up good quality standards, I would be happy if yoy help me with any needed improvements as I am still a beginner :)