Merge pull request #816 from jessica-jordan/code-corps-api#692/add-va…

…lidation-to-donation-goals-pos-numbers-only

Code corps api#692/add validation to donation goals: positive numbers only

test/models/donation_goal_test.exs

@@ -26,6 +26,15 @@ defmodule CodeCorps.DonationGoalTest do
       refute changeset.valid?
       changeset |> assert_error_message(:project, "does not exist")
     end
+
+    test "amount must not be negative" do
+      attrs = %{amount: -100, description: "Cashback for donators", project_id: 2}
+      donation_goal = insert(:donation_goal)
+      changeset = DonationGoal.create_changeset(donation_goal, attrs)
+
+      refute changeset.valid?
+      changeset |> assert_error_message(:amount, "must be greater than %{number}")
+    end
   end
 
   describe "&update_changeset/2" do

web/models/donation_goal.ex

@@ -30,6 +30,7 @@ defmodule CodeCorps.DonationGoal do
     struct
     |> cast(params, [:amount, :description, :project_id])
     |> validate_required([:amount, :description, :project_id])
+    |> validate_number(:amount, greater_than: 0)
     |> assoc_constraint(:project)
   end