Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add part_type to conversation parts #1318

Closed
joshsmith opened this issue Dec 20, 2017 · 2 comments
Closed

Add part_type to conversation parts #1318

joshsmith opened this issue Dec 20, 2017 · 2 comments
Assignees
@snewcomer
Labels
Difficulty: Easy in progress Time: 1 hour
Milestone
✉️ Messages

Comments

@joshsmith
Copy link
Contributor

joshsmith commented Dec 20, 2017 •
edited
Loading

Problem

We need to add a part_type to the schema for ConversationPart.

It should validate inclusion in:

  • "comment"
  • "note"
  • "reopened"
  • "closed"
@joshsmith joshsmith added this to the ✉️ Messages milestone Dec 20, 2017
This was referenced Dec 20, 2017
Open
Open
@joshsmith joshsmith mentioned this issue Dec 20, 2017
Closed
@snewcomer snewcomer self-assigned this Dec 20, 2017
@snewcomer
Copy link
Contributor

@joshsmith is there a default for this?

@snewcomer
Copy link
Contributor

and is null == false?

@snewcomer snewcomer mentioned this issue Dec 20, 2017
Merged
@zacck-zz zacck-zz mentioned this issue Feb 15, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snewcomer snewcomer

Labels
Difficulty: Easy in progress Time: 1 hour
Projects
None yet
Milestone
✉️ Messages
Development

No branches or pull requests
2 participants
@joshsmith @snewcomer