Add part_type to conversation_part #1325
Conversation
snewcomer
force-pushed
the
part-type
branch
2 times, most recently
from
0253fb9
to
970c1c2
Compare
| @@ -24,9 +25,14 @@ defmodule CodeCorps.Messages.ConversationParts do | |||
| @spec create_changeset(ConversationPart.t, map) :: Ecto.Changeset.t | |||
| def create_changeset(%ConversationPart{} = conversation_part, attrs) do | |||
| conversation_part | |||
| |> cast(attrs, [:author_id, :body, :conversation_id]) | |||
| |> cast(attrs, [:author_id, :body, :conversation_id, :part_type]) | |||
There was a problem hiding this comment.
I'm guessing this will need an update cast as well? Don't see an update action however.
There was a problem hiding this comment.
I don't think we would cast this in an update, since the part type should never change.
| @@ -24,9 +25,14 @@ defmodule CodeCorps.Messages.ConversationParts do | |||
| @spec create_changeset(ConversationPart.t, map) :: Ecto.Changeset.t | |||
| def create_changeset(%ConversationPart{} = conversation_part, attrs) do | |||
| conversation_part | |||
| |> cast(attrs, [:author_id, :body, :conversation_id]) | |||
| |> cast(attrs, [:author_id, :body, :conversation_id, :part_type]) | |||
There was a problem hiding this comment.
I don't think we would cast this in an update, since the part type should never change.
| @@ -19,6 +19,7 @@ defmodule CodeCorps.ConversationPart do | |||
| schema "conversation_parts" do | |||
| field :body, :string, null: false | |||
| field :read_at, :utc_datetime, null: true | |||
| field :part_type, :string | |||
There was a problem hiding this comment.
I would make this default: "comment" so it doesn't have to be specified for most cases.
There was a problem hiding this comment.
How does it get set to any other type? If I set it to a default, I can figure out a way to test the part_type since it doesn't get included in the changeset...
|
|
||
| def change do | ||
| alter table(:conversation_parts) do | ||
| add :part_type, :string |
There was a problem hiding this comment.
With above comment, should add default: "comment".
| @@ -8,14 +8,42 @@ defmodule CodeCorps.Messages.ConversationPartsTest do | |||
| } | |||
|
|
|||
| @valid_attrs %{ | |||
| body: "Test body." | |||
| body: "Test body.", | |||
| part_type: "comment" | |||
There was a problem hiding this comment.
You can remove this line and the tests should still pass, with the changes mentioned above.
There was a problem hiding this comment.
If I set to a default, do I need to do something in the changeset chain to include it in the changes?
There was a problem hiding this comment.
No it’ll just get set if it’s not set. Remember Ecto is still just an adapter to SQL.
snewcomer
force-pushed
the
part-type
branch
4 times, most recently
from
7ba4e64
to
9f7c7aa
Compare
| attrs = @valid_attrs |> Map.merge(%{author_id: 1, conversation_id: 1}) | ||
| {:ok, conversation} = ConversationParts.create_changeset(%ConversationPart{}, attrs) |> Repo.insert | ||
| assert conversation.body == "Test body." | ||
| assert conversation.part_type == "comment" |
There was a problem hiding this comment.
I think you also probably want to assert the conversation.user_id here is equal to the user.id.
Fixes #1318