Use modified_at in Task to ensure the last write wins #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing I don't like about this is that I had to change e.g. in all the JSON |
begedin
previously approved these changes
Oct 10, 2017
Add TimeValidator and validation
joshsmith
force-pushed
the
1035-modified-at-task
branch
from
d3319ac
to
e881137
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This simply adds a custom validation to the
Issues.ChangesetBuilderthat checks whether themodified_atis after themodified_atwe're trying to set, and if so, then errors.References
Fixes #1035
Fixes #1036