-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add analytics tracking for core actions #1105
Add analytics tracking for core actions #1105
Conversation
@moduledoc false | ||
@moduledoc false | ||
@moduledoc false | ||
@moduledoc false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😂
Looks like we had a bug in our Making that clause specific to the token and fixing test failures means we need to open up several issues. I'll list them here, so I can create them later
|
a32a3e0
to
e931497
Compare
Our |
Other things we may want to consider
|
I've spent time trying to implement tracking for the case of a position change. However, due to our use of
For now, best I could do is add the order field to the task traits in tracking and work with "Edited Task". If you have a better idea, I'm happy to implement it. |
On the note of GithubAppInstallation tracking
The problem with this new tracking, however, is that there's no |
@joshsmith As you can see, this was not going up to plan, exactly, and there are questions we need to resolve. At the very least, some issues need to be created, but the PR on its own should be ready for a review. |
- Added added/removed TaskSkill - Fixed catch-all clause issue with segment traits builder, added UserTask tracking - Added Task Github connect tracking. Fixed task service not allowing github connect in update - Added tracking for ProjectSkill - Added tracking for task move between lists - Added extra task traits - Added Task title change tracking - Added task close tracking - Added Task archive tracking - Added tracking for GithubAppInstallation created - Added ProjectGithubRepo tracking
ac78457
to
067c3fa
Compare
What's in this PR?
References
Progress on #1038