-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pagination support to GitHub.API.Installation.repositories #1162
Add pagination support to GitHub.API.Installation.repositories #1162
Conversation
It looks like this is erroring due to the fact that For example, the list returned seems to be:
And |
@joshsmith Took me a bit to get here, but I managed to write some behavior which should allow us to more easily recover from various potential issues during a paginated request. There were a bunch of inconsistencies that needed fixing, as well as miscellaneous minor corrections I had to do to get to that point, but overall, this should increase stability. Just as a minor tip, I found that looking at dialyzer errors, which we have quite a lot of, using The commit message should clarify what I did but I'll also copy it here for convenience
|
This looks great to me. I can't approve since it's my PR, but will rebase and merge now. Great work! |
b850c0a
to
0a5d957
Compare
- added API.Errors namespace, to move other errors into - added API.Errors.PaginationError - rewrote some specs that were breaking contracts - standardized get_all response to match request response - corrected several type definitions - added support for recovering from failed individual page requests during get_all - added support for recovering from failed initial head request during get_all - added support for marshalling a failed and succesful head response (body is "") - rewrote ResultAggregator docs and argument names so they reflect the fact that it can be used for aggregating any standard response list, not just db commit - wrote tests to cover new behaviors
0a5d957
to
84c5435
Compare
What's in this PR?
Adds pagination support to
GitHub.API.Installation.repositories
.Wasn't sure if a test was necessary given that it was failing until I got it working. Don't think we need to do extra testing for this to be paginating.
Any thoughts here?
References
Fixes #1108