Set modified_from to "code_corps" on tasks and comments when updating from codecorps #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begedin
commented
Nov 7, 2017
| {:ok, updated_comment} = comment |> Comment.Service.update(@update_attrs) | ||
|
|
||
| assert updated_comment.modified_from == "code_corps" | ||
| end |
There was a problem hiding this comment.
A changeset test might seem enough, but I wanted to add a sort of "integration" test to. The service is where the modification gets commited to the db.
begedin
commented
Nov 7, 2017
| test "sets task :modified_from to 'github'" do | ||
| %{github_issue: github_issue, user: user} = setup_test_data() | ||
| {:ok, tasks} = github_issue |> IssueTaskSyncer.sync_all(user) | ||
| assert tasks |> Enum.all?(fn task -> task.modified_from == "github" end) |
There was a problem hiding this comment.
For the same reason as the service test above, this is a sort of an integration test, even though our sync changeset already has the needed assertions in its own tests.
I did not do the same for comments because of the complexity of the test data there. I'm hoping I'll get a chance to decouple the comment syncer from payloads first.
joshsmith
approved these changes
Nov 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR makes it so that every time a task or comment is modified from the client application, thus, from CodeCorps, not some other location, the
:modified_fromfield on thatTaskorCommentrespectively is set to"code_corps"."code_corps"was already our field default, so I wen't with that, instead of"codecorps"as instructed in the issue.Since it was our field default, the field was set correctly upon initial creation from the client app. However, a subsequent modification from github, followed by modification from codecorps, would result in
:modified_frombeing incorrectly stuck on"github", even though the last source of the modification was in fact the client app.Note that the
create_changesetis also used in our seeds. It makes sense as it is, but if we want to seed our db with tasks or comments linked to github, we need to take that into account.References
Fixes #1145