Add processor that switches between sync/async #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@begedin as a first go, how does this look to you compared to the alternative? I will fix those tests. Also wow, test coverage? What? |
Remove need for BackgroundProcessingCase
joshsmith
force-pushed
the
add-processor
branch
from
d4c74b3
to
ce9efc1
Compare
|
@begedin I merged this because it's such a painful state for me right now. If you have some changes you'd like made, could you open a followup issue for them? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Attempting to fix some of the following errors:
There will now be some failing tests due to areas where the logic won't work synchronously.