Dialyzer Fixes #1237
Merged
Dialyzer Fixes #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshsmith
reviewed
Nov 23, 2017
| @@ -33,12 +32,12 @@ defmodule CodeCorps.GitHub.Event.PullRequest do | |||
| end | |||
| end | |||
|
|
|||
| @spec validate_payload(map) :: {:ok, :valid} | |||
| | {:error, :unexpected_payload} | |||
| @spec validate_payload(map) :: {:ok, :valid} | {:error, :unexpected_payload} | |||
There was a problem hiding this comment.
I think the old spec is maybe how the formatter is doing it now?
There was a problem hiding this comment.
Oh possibly. It was inconsistent across the handlers, so I just normalized them by hand. I can change it back if you want, but considering the discussion note in the PR, I feel like this code could be moved to the caller at some point soon. Your call, though.
|
Can you rebase and squash into a single commit? Then I'll approve and we can merge. |
asummers
force-pushed
the
fix-dialyzer-1
branch
from
69af5fe
to
23595cb
Compare
asummers
force-pushed
the
fix-dialyzer-1
branch
from
23595cb
to
6406d66
Compare
joshsmith
approved these changes
Nov 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved about 10 dialyzer errors, and converted case with true/false to if/else.
Discussion: the event handlers seem to all be doing the same high level logic. Perhaps it might be better to expose a
validator/0that returns a validator module, and move the with/else logic to the caller. Haven't gone through all of them yet, but I could see that being advantageous.