Improve organization creation #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
begedin
reviewed
Nov 28, 2017
| |> OrganizationInvite.update_changeset(%{organization_id: organization_id}) | ||
| |> Repo.update() | ||
| end | ||
| defp fulfill_associated_invite(%Organization{}, %{}), do: {:ok, nil} |
There was a problem hiding this comment.
I added this to support the old "creation by admin" behavior. I know it's not actually used anywhere, but i think the options then should be either remove it, or keep it working. Breaking it and leaving it in while broken adds confusion.
begedin
reviewed
Nov 28, 2017
| def get_organization_invite(%{"code" => code}), | ||
| do: OrganizationInvite |> Repo.get_by(code: code, fulfilled: false) | ||
| def get_organization_invite(%{}), do: nil | ||
|
|
There was a problem hiding this comment.
Moved it to Policy.Organization since it's the only place it's used in and we don't test ti directly.
- Add Organizations modules and fix changesets, add migration - Changed fulfillment behavior to be code based - Updated API docs - Added explicit flagging as unapproved when creating organization - Add test coverage for slug generation behavior
joshsmith
force-pushed
the
improve-organization-creation
branch
from
ade6ee2
to
11da4e1
Compare
|
I can't approve since it's my PR, but looks good. Merging when tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Still needs tests.