Add conversation part controller #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begedin
requested changes
Dec 15, 2017
|
|
||
| assert rendered_json == expected_json | ||
| end | ||
| end |
There was a problem hiding this comment.
Did you move this here by accident?
| conversation_id: conversation.id | ||
| } | ||
|
|
||
| {:ok, %ConversationPart{}} = Messages.add_part(attrs) |
There was a problem hiding this comment.
Should at least assert it belongs to the conversation here, if not checking the rest of the attributes.
| assert result.id == conversation.id | ||
| end | ||
|
|
||
| test "should return conversation of a Conversation" do |
There was a problem hiding this comment.
This returns it for a conversation part
begedin
previously approved these changes
Dec 15, 2017
joshsmith
force-pushed
the
1291-conversation-part-controller
branch
from
7f2d520
to
8a108ce
Compare
begedin
approved these changes
Dec 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
create_changesetcreate_changesetPolicy.ConversationPart.create?Policy.ConversationPart.create?Messages.create_conversation_part(params)Messages.ConversationPart.createcreate_changesetMessages.create_conversation_part(params)create_changesetis private, make sure to test casting behavior toConversationPartController:createendpointMessages.create_conversation_part:createendpointPolicy.ConversationPart.show?Policy.ConversationPart.show?ConversationPartController:showendpoint:showendpointPolicy.ConversationPart.scope/2ConversationPartrecords belonging toConversationrecords defined byPolicy.Conversation.scope/2Policy.ConversationPart.scope:indexendpointconversation.conversationPartsin the clientconversation_id, but not sure yet:indexendpointReferences
Fixes #1291
Fixes #1290
Fixes #1289