Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

limit scope to comment part type #1344

Merged
merged 2 commits into from
Dec 27, 2017
Merged

limit scope to comment part type #1344

merged 2 commits into from
Dec 27, 2017

Conversation

snewcomer
Copy link
Contributor

@snewcomer snewcomer commented Dec 26, 2017 •
edited

References

Fixes #1322

@snewcomer snewcomer self-assigned this Dec 26, 2017
begedin
begedin approved these changes Dec 27, 2017
View reviewed changes
Copy link
Contributor

@begedin begedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems correct to me, and good to go 👍

Thank you @snewcomer

@begedin begedin merged commit 166ff1a into develop Dec 27, 2017
@begedin begedin deleted the limit-part-scope branch December 27, 2017 16:18
zacck-zz pushed a commit that referenced this pull request Feb 14, 2018
@snewcomer @zacck
Scope CommentPart records to "comment" type for regular users (#1344)
c4cb19c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begedin begedin begedin approved these changes

@joshsmith joshsmith Awaiting requested review from joshsmith

Assignees

@snewcomer snewcomer

Labels
Difficulty: Easy needs code review Skill: Elixir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@snewcomer @begedin