Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webhook for account external account created #580

Merged
merged 1 commit into from
Dec 20, 2016

Conversation

joshsmith
Copy link
Contributor

@joshsmith joshsmith commented Dec 17, 2016

What's in this PR?

Handling for the "account.external_account.created" webhook event.

Closes #573

@joshsmith
Copy link
Contributor Author

Wait why did you remove the adapter?

@paulsullivanjr
Copy link
Contributor

paulsullivanjr commented Dec 17, 2016 via email

@begedin begedin force-pushed the 573-webhook-for-account-external-account-created branch from e5430cf to 6409b43 Compare December 19, 2016 14:48
@begedin
Copy link
Contributor

begedin commented Dec 19, 2016

Unless I'm missing something, this ought to be ready now.

The issue mentions a user_id, but our stripe_external_account records do not have that field. Should it be added?

@begedin begedin self-assigned this Dec 19, 2016
@@ -1,7 +1,7 @@
defmodule CodeCorps.StripeConnectEventsControllerTest do
use CodeCorps.ConnCase

alias CodeCorps.{Project, StripeConnectAccount, StripeEvent}
alias CodeCorps.{Project, StripeConnectAccount, StripeExternalAccount, StripeEvent}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny issue, but v and then x.

@joshsmith
Copy link
Contributor Author

@begedin I can't approve but this is approved. Rebase, merge.

@begedin begedin force-pushed the 573-webhook-for-account-external-account-created branch from 5b5a199 to 77a10fc Compare December 20, 2016 11:36
@begedin begedin merged commit 7c0e7c5 into develop Dec 20, 2016
@begedin begedin deleted the 573-webhook-for-account-external-account-created branch December 20, 2016 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants