Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stripe tracking for some basic cases #591

Merged
merged 2 commits into from
Jan 19, 2017
Merged

Add stripe tracking for some basic cases #591

merged 2 commits into from
Jan 19, 2017

Conversation

begedin
Copy link
Contributor

@begedin begedin commented Dec 28, 2016

What's in this PR?

PR adds missing tracking calls and tests for the basic cases related to the whole stripe process:

  • stripe connect subscription testing - tracking was already in
  • donation goals create - wasn't tracked or tested
  • donation goals update - wasn't tracked or tested

References

Progress on: #525

@begedin begedin changed the title 525 add stripe tracking Add stripe tracking for some basic cases Dec 28, 2016
sbatson5
sbatson5 approved these changes Jan 19, 2017
View reviewed changes
Copy link
Contributor

@sbatson5 sbatson5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Just needs a rebase.

@joshsmith
Copy link
Contributor

Thanks for review @sbatson5!

@begedin begedin merged commit e8a931c into develop Jan 19, 2017
@begedin begedin deleted the 525-add-stripe-tracking branch January 19, 2017 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbatson5 sbatson5 sbatson5 approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@begedin @joshsmith @sbatson5