Moved code from handler for "account.updated" into StripeConnectAccountService #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begedin
commented
Jan 12, 2017
| else | ||
| {:error, %Ecto.Changeset{} = changeset} -> {:error, changeset} | ||
| {:error, %Stripe.APIErrorResponse{} = error} -> {:error, error} | ||
| _ -> {:error, :unhandled} |
There was a problem hiding this comment.
This is outright error hiding and should go away, so I removed it.
begedin
commented
Jan 12, 2017
| else | ||
| {:error, %Ecto.Changeset{} = changeset} -> {:error, changeset} | ||
| {:error, %Stripe.APIErrorResponse{} = error} -> {:error, error} |
There was a problem hiding this comment.
This one serves no function. It passes out the error response. Not having this line leaves behavior exactly the same.
begedin
commented
Jan 12, 2017
| else | ||
| {:error, %Ecto.Changeset{} = changeset} -> {:error, changeset} |
There was a problem hiding this comment.
Removing this one means the call in the do block will just do the same thing automatically.
begedin
commented
Jan 12, 2017
| do | ||
| {:ok, updated_account} | ||
| account |> StripeConnectAccount.webhook_update_changeset(params) |> Repo.update |
There was a problem hiding this comment.
This call will return {:ok, updated_account} anyway. No point in first calling it in the with block, then just passing it through in the do block.
joshsmith
approved these changes
Jan 12, 2017
begedin
force-pushed
the
consolidate-stripe-connect-account-crud-code
branch
from
611f3b9
to
6ed9a91
Compare
begedin
changed the title
begedin
force-pushed
the
consolidate-stripe-connect-account-crud-code
branch
from
6ed9a91
to
8b4ed28
Compare
joshsmith
force-pushed
the
consolidate-stripe-connect-account-crud-code
branch
from
8b4ed28
to
cf719d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Figured this out while working on #625
For consistency, I moved the code from the "account.updated" handler into
StripeConnectAccountService.update_from_stripe.I also removed some
elsecases from all 3 functions there, since they either just propagate the error response (basically doing nothing), or they outright swallow errors.We should also add an issue, good for contributors to add a test for
StripeConnectAccountService.update_from_stripe/1- created #628