Project has can-activate-donations on its view #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshsmith
force-pushed
the
project-can-activate-donations
branch
from
eb8a619
to
0d4b64c
Compare
begedin
requested changes
Jan 15, 2017
| - `Organization` with a `StripeConnectAccount`, in production env, which | ||
| has `charges_enabled: true` and `transfers_enabled: true` | ||
| - `Organization` with a `StripeConnectAccount` and | ||
| `transfers_enabled: true`, not in production env |
There was a problem hiding this comment.
I'm not sure what my original reasoning was for this (I was the one originally implementing the validator), but I'm not seeing the benefits in splitting up the environments here.
I think it may have just been for easier manual testing, so I'm considering it might be a good idea to just ditch the check for the correct environment.
It should just be
Organizationwith aStripeConnectAccount, which hascharges_enabled: trueandtransfers_enabled: true
I would remove the method on line 38 and update the documentation.
There was a problem hiding this comment.
@begedin I think it's because charges_enabled is always true in some environments? Not sure.
joshsmith
force-pushed
the
project-can-activate-donations
branch
from
0d4b64c
to
9724296
Compare
begedin
approved these changes
Jan 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Closes #630.