Separate IgnoredEventHandler behavior for connect and platform events. #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begedin
force-pushed
the
645-split-up-event-handler
branch
from
6074ad9
to
ed930d6
Compare
begedin
commented
Jan 19, 2017
| defp get_platform_reason("customer.source.created"), do: "Cards are only created from the client. No need to handle" | ||
| defp get_platform_reason("customer.subscription.created"), do: "Subscriptions are only created from the client." | ||
| defp get_platform_reason("invoice.created"), do: "We prefer to handle other lifecycle events for invoices, like payment_succeeded." | ||
| defp get_platform_reason("plan.created"), do: "Plans are only created from the client." |
There was a problem hiding this comment.
I'm aware there is some code duplication here and we could reduce it but I feel it's clearer to keep the mapping of messages to event types separate. It also allows us to change the actual text based on the type of webhook that got hit.
joshsmith
approved these changes
Jan 19, 2017
begedin
force-pushed
the
645-split-up-event-handler
branch
from
ed930d6
to
d140ae4
Compare
begedin
force-pushed
the
645-split-up-event-handler
branch
from
d140ae4
to
deb8f5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR changes behavior of the
IgnoredEventHandlermodule to work separately for connect platform events. This allows us, for example, to ignore a certain event type when it hits the platform webhook, while still handling it on the connect webhook, or vice-versa.It also allows us to have separate ignore reasons for different endpoints.
Finally, it adds an explicit ignore for the "customer.updated" event on the connect webhook. The event is still being handled normally on the platform webhook.
References
Fixes #645