TaskSkill model, policies and endpoints #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begedin
changed the title
joshsmith
requested changes
Feb 1, 2017
| refute create?(user, changeset) | ||
| end | ||
|
|
||
| test "returns false when user is contributor of organization" do |
There was a problem hiding this comment.
I think we want this to be true for contributors.
| end | ||
|
|
||
| test "returns false when user is contributor of organization" do | ||
| {user, task} = generate_data_for("contributor") |
begedin
force-pushed
the
670-task-skill-model-policies-endpoints
branch
2 times, most recently
from
43a535c
to
9b8f4ef
Compare
|
@joshsmith Made the change, rebased, should be good to go. |
joshsmith
approved these changes
Feb 1, 2017
begedin
force-pushed
the
670-task-skill-model-policies-endpoints
branch
from
4c1f108
to
fcc3f5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Added required infrastructure to create, delete and view TaskSkill records
References
Fixes #670
Progress on: #667