Fix cloudex configuration #701
Conversation
There was a problem hiding this comment.
Looking from my phone, it's hard to judge, but you might be tackling two separate things here. Look into the cloudex docs to see how they handle testing and see which parts we need to change here and which we don't.
It's possible this is all good, but I'm not sure from my phone.
| if System.get_env("CLOUDEX_API_KEY") == nil do | ||
| config :cloudex, :cloudinary_api, Cloudex.CloudinaryApi.Test |
There was a problem hiding this comment.
This is actually a documented Cloudex approach of enabling test mode for the API. Don't have a link right now, but should probably look into the Clodex docs to see what it does. Not sure if we wanna remove it.
There was a problem hiding this comment.
We don't make use of the API, so don't really need it right now.
| IO.puts("NOTE: No Cloudex configuration found. Cloudex is runnning in test mode.") | ||
| config :code_corps, :cloudex, CloudexTest |
There was a problem hiding this comment.
I think this is what fixes it. The removal of the other change probably doesn't break anything right now, but might be misleading.
There was a problem hiding this comment.
Yeah, I'm going to move this out of helpers too and into a dedicated cloudex.
| @@ -1,4 +1,4 @@ | |||
| defmodule Cloudex.CloudinaryApi.Test do | |||
There was a problem hiding this comment.
This is probably the other part of the fix.
joshsmith
force-pushed
the
fix-cloudex-config
branch
from
a02b973
to
4ab1d62
Compare
joshsmith
force-pushed
the
fix-cloudex-config
branch
from
4ab1d62
to
13aa82d
Compare
What's in this PR?
This fixes some Cloudex config issues that made it into a merge.