Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API Blueprint and reorder routes to mirror it #762

Merged
merged 2 commits into from
Mar 17, 2017
Merged

Update API Blueprint and reorder routes to mirror it #762

merged 2 commits into from
Mar 17, 2017

Conversation

joshsmith
Copy link
Contributor

What's in this PR?

Closes #593

Does some significant updates on the API Blueprint.

The diff is large, so requires some parsing.

Also reordered routes to mirror the blueprint, so it would be easier to visually reference one to the other.

snewcomer
snewcomer approved these changes Mar 17, 2017
View reviewed changes
Copy link
Contributor

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Can't tell if most of the error handling scenarios was in before, but great to see them there!

@joshsmith joshsmith merged commit 3707679 into develop Mar 17, 2017
@joshsmith joshsmith deleted the update-api-blueprint branch March 17, 2017 19:07
@joshsmith
Copy link
Contributor Author

🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snewcomer snewcomer snewcomer approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshsmith @snewcomer