-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INITIAL SETUP Add github issue webhook #794
Conversation
web/router.ex
Outdated
@@ -55,6 +55,8 @@ defmodule CodeCorps.Router do | |||
|
|||
post "/webhooks/stripe/connect", StripeConnectEventsController, :create | |||
post "/webhooks/stripe/platform", StripePlatformEventsController, :create | |||
post "/webhooks/github_issues", GithubIssueController, :create | |||
post "/webhooks/github_issue_comments", GithubIssueCommentController, :create |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you feel about calling these actions :handle
. I feel :create
is a bit misleading here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think that makes sense 👍
09a0349
to
5662033
Compare
@npendery We did a lot of stuff since this was submitted, and we ended up implementing basic handling for several issue webhooks as part of a different PR, as we were figuring out the major stuff. I'm sorry about that, but your work here is still appreciated. Simply put, we needed some webhook to figure out the process and this one was relatively straightforward compared to others. |
What's in this PR?
Adding webhooks to connect to GitHub
References
Progress on: #786