Mock out pem access #840
Merged
Mock out pem access #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshsmith
approved these changes
Jul 6, 2017
config/test.exs
Outdated
|
|
||
| # supply sample .pem with RSA_PRIVATE_KEY for tests | ||
| config :code_corps, | ||
| github_app_pem: "./test/fixtures/github/app.pem" |> File.read! |
There was a problem hiding this comment.
We have an actual PEM on CI, so I wonder if this shouldn't be an || statement somehow.
begedin
force-pushed
the
mock-out-pem-access
branch
from
44a342f
to
eee47d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #823
This PR adds a test fixture for a
.pemfile, used when authenticating a github request. It sets up the app configuration so that the.pemcontent is loaded from this fixture in the test environment, instead of being loaded from an environment variable, as it is in other cases.This should Joken related GitHub tests to pass, for users who do not have the actual pem in their environment.
The test file simply contains a random RSA private key, since this is all we need for the process to work.