Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github-app-installations relationship to be available on user view #871

Merged
merged 1 commit into from
Aug 30, 2017

Conversation

joshsmith
Copy link
Contributor

@joshsmith joshsmith commented Aug 30, 2017

What's in this PR?

This fixes the UserView to have github-app-installations relationships available on it, otherwise the Ember app does not have any unconnected installations to display for the user.

Also adds a test for this behavior.

@joshsmith joshsmith added this to the GitHub integration milestone Aug 30, 2017
@joshsmith joshsmith requested a review from begedin August 30, 2017 01:20
@begedin
Copy link
Contributor

begedin commented Aug 30, 2017

Good catch. Figured I'd miss something.

@begedin begedin merged commit 392541d into develop Aug 30, 2017
@begedin begedin deleted the fix-github-app-installations-on-user branch August 30, 2017 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants