Added "github" context to users created during github sync #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begedin
force-pushed
the
948-add-signup-context-to-github-user
branch
from
f254823
to
f410ef9
Compare
|
The Phoenix docs on contexts seem to indicate that a pluralized form – |
joshsmith
reviewed
Sep 20, 2017
lib/code_corps/account/account.ex
Outdated
| %User{} | ||
| |> Changeset.change(attrs |> Adapters.User.from_github_user()) | ||
| |> Changeset.put_change(:context, "github") | ||
| |> Changeset.unique_constraint(:email) |
There was a problem hiding this comment.
What happens if the email is nil? GitHub is not guaranteed to return one.
There was a problem hiding this comment.
We already merged in a PR where a user can be inserted without an email, so we should be fine. Really, what's important for us here is the github id, so we can associate this "stub" with an actual user later, when they connect with github.
I don't feel strongly about it one way or another. I can make the quick change |
begedin
force-pushed
the
948-add-signup-context-to-github-user
branch
from
f410ef9
to
5e6d0ea
Compare
joshsmith
previously approved these changes
Sep 20, 2017
- added Accounts bounded context - added Accounts.create_from_github - added AccountsTest - added user.json github fixture
begedin
force-pushed
the
948-add-signup-context-to-github-user
branch
from
5e6d0ea
to
46b51a6
Compare
joshsmith
approved these changes
Sep 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #948
Issues.UserLinkerandIssueComment.UserLinkerended up needing the exact same change and are quite similar to begin with. Instead of trying to force this into aGithub.Event.Commonmodule, I figured this is a good opportunity to start aCodeCorps.Accountbounded context, with its first function,Account.create_from_github/1Accountbounded contextAccount.create_from_github/1AccountTestfixtures/github/endpoint/user.jsonThe context is simply
"github"since the whole idea is that the user being created originates from github.