Propagate comment changes to GitHub comments #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…refactors - if task params containg a "github_repo_id", an issue is created on github alongside task and task is associated with issue - refactors: - removed reliance on ja_resource and canary from task controller - extracted task creation into separate module - extracted task-related queries into separate module - removed some unused code - moved some code around to follow boundex context convention - fixed several dialyzer warnings
|
@begedin I have since had to address bugs that cropped up in this and were not caught in tests. We need to test this out against actual API endpoints before things go up for code review. Mocks only go so far and this was a case where the mocks were lying to us about what the endpoints actually looked like. This should now work and be ready for review. |
|
There's an argument to be made here that we should be doing some actual integration tests. |
joshsmith
force-pushed
the
801-802-propagate-comment-changes-to-github-comments
branch
from
5ef76cd
to
e9cd37e
Compare
|
If this looks good, please do squash into a single commit and then merge. |
begedin
approved these changes
Sep 27, 2017
begedin
deleted the
801-802-propagate-comment-changes-to-github-comments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This somehow was not merged properly before into anything. I'm not quite sure what happened.