Fix a number of warnings and change log levels #987
Conversation
joshsmith
force-pushed
the
fix-warnings
branch
from
3c14180
to
2d5357d
Compare
|
It works! Only warning (compiler or otherwise) comes from upstream dep: |
There was a problem hiding this comment.
Nice @joshsmith!
Just for reference, this is a really good article if you haven't seen it.
https://www.amberbit.com/blog/2017/8/3/time-zones-in-postgresql-elixir-and-phoenix/
| @@ -3,7 +3,7 @@ defmodule CodeCorps.Repo.Migrations.AddStripeCustomersCardsTables do | |||
|
|
|||
| def change do | |||
| create table(:stripe_customers) do | |||
| add :created, :datetime | |||
| add :created, :utc_datetime | |||
There was a problem hiding this comment.
@joshsmith no need to replace field :created, :utc_datetime as well in the model?
There was a problem hiding this comment.
One thing I have seen done is for other models
@timestamps_opts [type: :utc_datetime] in the model file.
There was a problem hiding this comment.
Would you mind opening an issue for this? I'd like to migrate everything over to it specifically. We're lucky in the sense that the servers are all on UTC time by default so it shouldn't be a pain to migrate. But this is something that needs done ASAP.
There was a problem hiding this comment.
For now, I'm just trying to fix compiler warnings that will always be there unless we fix old migrations. That one was from Oct 2016!
There was a problem hiding this comment.
Cool. I'll open an issue.
What's in this PR?
:datetime. I saw no harm in changing them to:utc_datetimeinstead.Logger.warntoLogger.infoin a few places