Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loading state to volunteer-headshot component #1221

Open
3 tasks
joshsmith opened this issue Mar 29, 2017 · 5 comments
Open
3 tasks

Add loading state to volunteer-headshot component #1221

joshsmith opened this issue Mar 29, 2017 · 5 comments

Comments

@joshsmith
Copy link
Contributor

Problem

The volunteer-headshot should have some loading states for async data.

Subtasks

  • Add a light gray background for the image as a placeholder, until loaded (keeping in mind that a user may have a transparent PNG, so the background shouldn't remain gray)
  • Add a light gray rectangular area for the user's name as a placeholder, until loaded
  • Add a light gray rectangular area for the user's role as a placeholder, until loaded
@alistermada
Copy link

Is this okay? This was shot while using the mirage fake API with 4 sample users.
ccshot

@joshsmith
Copy link
Contributor Author

@alistermada wow sorry for super long delay here. Missed this notification somehow. This looks perfect! Are you ready to submit a PR for it?

@alistermada
Copy link

Sorry it's been a while since I worked on this fix. I still need to figure out how to change the tests to make them pass this new code.

@joshsmith
Copy link
Contributor Author

If you want to push up the changes, then I can give some pointers on how to accomplish that.

@joshsmith
Copy link
Contributor Author

Opening a PR is a good first step so we can start the conversation around it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants