Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed compile warning in converter.ex #528

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Fixed compile warning in converter.ex #528

merged 1 commit into from
Aug 7, 2019

Conversation

esvinson
Copy link
Contributor

@esvinson esvinson commented Aug 2, 2019

Previously:

Compiling 67 files (.ex)
[Warn  - 11:20:41 AM] warning: variable "value" is unused (if the variable is not meant to be used, prefix it with an underscore)
  lib/stripe/converter.ex:120

Generated stripity_stripe app

After

Compiling 67 files (.ex)
Generated stripity_stripe app

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.024% when pulling a019048 on esvinson:fix-compile-warnings into 952664e on code-corps:master.

snewcomer
snewcomer approved these changes Aug 7, 2019
View reviewed changes
Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@snewcomer snewcomer merged commit 521ec7f into beam-community:master Aug 7, 2019
@esvinson esvinson deleted the fix-compile-warnings branch August 7, 2019 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snewcomer snewcomer snewcomer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@esvinson @coveralls @snewcomer