Added support for constructors in UseInvokeMethodToFireEventAnalyzer

From #942.
code-cracker · Jun 27, 2017 · 7d7391c · 7d7391c
1 parent fe1b3ea
commit 7d7391c
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/src/CSharp/CodeCracker/Design/UseInvokeMethodToFireEventAnalyzer.cs b/src/CSharp/CodeCracker/Design/UseInvokeMethodToFireEventAnalyzer.cs
@@ -62,7 +62,7 @@ private static void Analyzer(SyntaxNodeAnalysisContext context)
 
         private static bool HasCheckForNullThatReturns(InvocationExpressionSyntax invocation, SemanticModel semanticModel, ISymbol symbol)
         {
-            var method = invocation.FirstAncestorOfKind(SyntaxKind.MethodDeclaration) as MethodDeclarationSyntax;
+            var method = invocation.FirstAncestorOfKind(SyntaxKind.MethodDeclaration, SyntaxKind.ConstructorDeclaration) as BaseMethodDeclarationSyntax;
             if (method != null && method.Body != null)
             {
                 var ifs = method.Body.Statements.OfKind(SyntaxKind.IfStatement);

diff --git a/test/CSharp/CodeCracker.Test/Design/UseInvokeMethodToFireEventTests.cs b/test/CSharp/CodeCracker.Test/Design/UseInvokeMethodToFireEventTests.cs
@@ -1134,6 +1134,23 @@ public void Bar()
     {
         var b = _filter != null && _filter();
     }
+}";
+            await VerifyCSharpHasNoDiagnosticsAsync(test.WrapInCSharpClass());
+        }
+
+        [Fact]
+        public async void IgnoreIfInConstructorAndThatCheckedForNotNull()
+        {
+            //https://github.com/code-cracker/code-cracker/issues/926
+            const string test = @"
+public class Foo
+{
+    public Foo(System.Action action)
+    {
+        if (action == null)
+            throw new System.ArgumentNullException();
+        action();
+    }
 }";
             await VerifyCSharpHasNoDiagnosticsAsync(test.WrapInCSharpClass());
         }