-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CC0122 Replace Task.Result with await Task #805
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This had to be done manually, as the other CodeAnalysis packages depend on version =1.0.0 of Microsoft.CodeAnalysis.Analyzers, so, if using VS to do this, it will auto upgrade all Microsoft.CodeAnalysis.* packages to 1.1.0 as well, which will keep the analyzer from working on VS 2015 RTM, only working on Update 1.
Allow now build from tags. Deploy now from tags not from the release branch anymore. For patches, now deploy to myget any branch that looks like a version number, like: v1.0.x v3.9.x Always ending with an `x`.
Fix 'BUG: CC0052 (Make readonly) should not be applied to complex value types code-cracker#775'
Fixes code-cracker#773 (Auto-generated files detection).
Adds Design Warning CC0122 when `System.Threading.Tasks.Task<TResult>.Result` is used in `async` method. The code fix provider replaces `.Result` with `async `
@AmadeusW You have some problem with your commits, you probably merged from CodeCracker's master into your branch, or something else. You can see that on the |
Taking a look at the commits, what you should do is:
Then open the PR with this branch, and close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #734
CC0122 Replace Task.Result with await Task
Adds Design Warning CC0122 when
System.Threading.Tasks.Task<TResult>.Result
is used inasync
method.The code fix provider replaces
.Result
withasync
Screenshot of a non trivial case:
![cc0122](https://cloud.githubusercontent.com/assets/1673956/16567981/5c63f2aa-422d-11e6-9859-5a45f5b5cbb8.png)