-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dataprovider): Add getColumnTypeByName method to KevinmasonProvider #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kjknows
commented
Mar 11, 2024
- added data provdier and json file
- added data provier and json file Closes: #123
anthonydmays
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nelshulla
pushed a commit
to Nelshulla/JadaN.Code
that referenced
this pull request
Mar 11, 2024
…ntly#167) - added data provier and json file Closes: code-differently#123
anthonydmays
added a commit
that referenced
this pull request
Mar 11, 2024
This reverts commit cfbe9c0.
|
||
import java.util.Map; | ||
|
||
public class KevinmasonProvider extends DataProvider { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're missing the @service annotation that will cause this file to get picked up by the tests. Please add and fix any issues you find.
anthonydmays
pushed a commit
that referenced
this pull request
Mar 11, 2024
* feat: adds Jada White date provider * feat: adds Randy lesson05 response (#172) * feat: added provider and .json * feat: added answers * chore: cleaned up comments * chore: fixed format * feat: Adds Chukwuma Ibezim.json and ChukwumaIbezimProvider.java (#171) * feat: adds Jamira's lesson 05 response (#170) -added Data Provider and JSON file * feat: adds Nataya's completed java test (#169) * feat(dataprovider): adds reponse to lesson 05 for Kevin (#167) - added data provier and json file Closes: #123 * chore: adds Kenrick's lesson 05 response (#173) * fix: changed package name * chore: added jada's white data provider --------- Co-authored-by: RandyCastr0 <160950862+RandyCastr0@users.noreply.github.com> Co-authored-by: cibezim <123107253+cibezim@users.noreply.github.com> Co-authored-by: CD-Jamira <160950455+CD-Jamira@users.noreply.github.com> Co-authored-by: NatayaP <160752534+NatayaP@users.noreply.github.com> Co-authored-by: kjknows <160962634+kjknows@users.noreply.github.com> Co-authored-by: Kenrixkk22 <160765704+Kenrixkk22@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.