-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Created a Librarian and media files #290
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntly-24-q1 into lesson10 merge main
anthonydmays
requested changes
Mar 25, 2024
lesson_10/solid/solid_app/src/main/java/com/codedifferently/lesson10/library/MediaItem.java
Show resolved
Hide resolved
anthonydmays
requested changes
Mar 26, 2024
@@ -32,6 +33,18 @@ public String getId() { | |||
return this.id; | |||
} | |||
|
|||
public void addMediaItem(MediaItem mediaItem) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there. With these methods, you shouldn't need to have methods addBook
, removeBook
, and hasBook
. You should be able to rename those methods, swap out Book
for MediaItem
and still see the tests pass.
Okay, I'll make those changes tomorrow. Thank you!
~Nataya
________________________________
From: Anthony D. Mays ***@***.***>
Sent: Tuesday, March 26, 2024 7:12 PM
To: code-differently/code-differently-24-q1 ***@***.***>
Cc: Nataya Price ***@***.***>; Author ***@***.***>
Subject: Re: [code-differently/code-differently-24-q1] feat: Created a Librarian and media files (PR #290)
@anthonydmays requested changes on this pull request.
________________________________
In lesson_10/solid/solid_app/src/main/java/com/codedifferently/lesson10/library/Library.java<#290 (comment)>:
@@ -32,6 +33,18 @@ public String getId() {
return this.id;
}
+ public void addMediaItem(MediaItem mediaItem) {
Almost there. With these methods, you shouldn't need to have methods addBook, removeBook, and hasBook. You should be able to rename those methods, swap out Book for MediaItem and still see the tests pass.
—
Reply to this email directly, view it on GitHub<#290 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BGKOHFUUQAM4STYO7ORTKALY2H6FLAVCNFSM6AAAAABFDVKDJ2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNRRHEZDEMZUGU>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a Librarian and media files