add 'field helper' concept to connections #62
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The concept here is that we want to be able to add the ability for certain inputs/connections to augment the fields being attached to them with certain helpers. Specifically, we want for Artist blocks with value inputs like this one
To still be able to show the Angle Helper:
This PR proposes a generic system to do that. When we define the inputs for the block, in addition to validation checks we can add a Field Helper like so:
And then Fields can consult
getFieldHelperOptions_
from withinshowEditor_
to see if they are (at the time of editing) in a connection hierarchy that wants them to show a helper, meaning we can dynamically display the angle helper based not on the field itself, but based on the input it's connected to!I'd love to get y'all's general thoughts on this approach.