-
Notifications
You must be signed in to change notification settings - Fork 479
/
test_files.rb
564 lines (432 loc) · 17.9 KB
/
test_files.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
require_relative 'files_api_test_base' # Must be required first to establish load paths
require_relative 'files_api_test_helper'
class FilesTest < FilesApiTestBase
def setup
@channel_id = create_channel
@api = FilesApiTestHelper.new(current_session, 'files', @channel_id)
@api.ensure_aws_credentials
end
def teardown
# Require that tests delete the assets they upload
get "v3/files/#{@channel_id}"
expected_empty_files = {
'files' => [],
'filesVersionId' => ''
}
assert_equal(expected_empty_files, JSON.parse(last_response.body))
delete_channel(@channel_id)
@channel_id = nil
end
def test_copy_object
file_data = 'fake-file-data'
old_filename = @api.randomize_filename 'old_file.html'
new_filename = @api.randomize_filename 'new_file.html'
delete_all_file_versions old_filename, URI.escape(old_filename),
new_filename, URI.escape(new_filename)
delete_all_manifest_versions
post_file_data @api, old_filename, file_data, 'test/html'
@api.copy_object old_filename, new_filename
assert successful?
@api.get_object(new_filename)
assert successful?
assert_equal file_data, last_response.body
@api.get_object(old_filename)
assert successful?
assert_equal file_data, last_response.body
delete_all_manifest_versions
end
def test_rename_object
file_data = 'fake-file-data'
old_filename = @api.randomize_filename 'old_file.html'
new_filename = @api.randomize_filename 'new_file.html'
delete_all_file_versions old_filename, URI.escape(old_filename),
new_filename, URI.escape(new_filename)
delete_all_manifest_versions
post_file_data @api, old_filename, file_data, 'test/html'
@api.rename_object old_filename, new_filename
assert successful?
@api.get_object(new_filename)
assert successful?
assert_equal file_data, last_response.body
@api.get_object(old_filename)
assert not_found?
@api.delete_object(new_filename)
assert successful?
delete_all_manifest_versions
end
def test_upload_files
dog_image_filename = @api.randomize_filename('dog.png')
dog_image_body = 'stub-dog-contents'
cat_image_filename = @api.randomize_filename('cat.png')
cat_image_body = 'stub-cat-contents'
# Make sure we have a clean starting point
delete_all_file_versions(dog_image_filename, cat_image_filename)
delete_all_manifest_versions
# Upload dog.png and check the response
response = post_file_data(@api, dog_image_filename, dog_image_body, 'image/png')
actual_dog_image_info = JSON.parse(response)
expected_dog_image_info = {
'filename' => dog_image_filename,
'category' => 'image',
'size' => dog_image_body.length
}
assert_fileinfo_equal(expected_dog_image_info, actual_dog_image_info)
# Upload cat.png and check the response
response = post_file_data(@api, cat_image_filename, cat_image_body, 'image/png')
actual_cat_image_info = JSON.parse(response)
expected_cat_image_info = {
'filename' => cat_image_filename,
'category' => 'image',
'size' => cat_image_body.length
}
assert_fileinfo_equal(expected_cat_image_info, actual_cat_image_info)
file_infos = @api.list_objects
assert_fileinfo_equal(actual_dog_image_info, file_infos['files'][0])
assert_fileinfo_equal(actual_cat_image_info, file_infos['files'][1])
@api.get_object(dog_image_filename)
assert_match 'private, must-revalidate, max-age=0', last_response['Cache-Control']
assert_equal dog_image_body, last_response.body
@api.get_root_object(dog_image_filename, '', {'HTTP_HOST' => CDO.canonical_hostname('codeprojects.org')})
assert_equal dog_image_body, last_response.body
@api.delete_object(dog_image_filename)
assert successful?
@api.delete_object(cat_image_filename)
assert successful?
delete_all_manifest_versions
end
def test_content_disposition
dog_image_filename = @api.randomize_filename('dog.png')
dog_image_body = 'stub-dog-contents'
html_filename = @api.randomize_filename('index.html')
html_body = 'stub-html-contents'
post_file_data(@api, dog_image_filename, dog_image_body, 'image/png')
post_file_data(@api, html_filename, html_body, 'text/html')
# Verify that we download non-whitelisted file types as an attachment when
# hitting the normal GET api.
@api.get_object(dog_image_filename)
assert successful?
assert_nil last_response['Content-Disposition']
@api.get_object(html_filename)
assert successful?
assert_equal "attachment; filename=\"#{html_filename}\"", last_response['Content-Disposition']
# Verify that we download the files without Content-Disposition when hitting
# the codeprojects.org root URL.
@api.get_root_object(dog_image_filename, '', {'HTTP_HOST' => CDO.canonical_hostname('codeprojects.org')})
assert successful?
assert_nil last_response['Content-Disposition']
@api.get_root_object(html_filename, '', {'HTTP_HOST' => CDO.canonical_hostname('codeprojects.org')})
assert successful?
assert_nil last_response['Content-Disposition']
@api.delete_object(dog_image_filename)
assert successful?
@api.delete_object(html_filename)
assert successful?
delete_all_manifest_versions
end
def test_allow_mismatched_mime_type
mismatched_filename = @api.randomize_filename('mismatchedmimetype.png')
delete_all_file_versions(mismatched_filename)
delete_all_manifest_versions
post_file_data(@api, mismatched_filename, 'stub-contents', 'application/gif')
assert successful?
@api.delete_object(mismatched_filename)
assert successful?
delete_all_manifest_versions
end
def test_escaping_insensitivity
filename = @api.randomize_filename('has space.html')
escaped_filename = URI.escape(filename)
filename2 = @api.randomize_filename('another has spaces.html')
escaped_filename2 = URI.escape(filename2)
delete_all_file_versions(filename, escaped_filename, filename2, escaped_filename2)
delete_all_manifest_versions
post_file_data(@api, filename, 'stub-contents', 'test/html')
assert successful?
@api.get_object(escaped_filename)
assert successful?
@api.delete_object(escaped_filename)
assert successful?
post_file_data(@api, escaped_filename2, 'stub-contents-2', 'test/html')
assert successful?
@api.get_object(escaped_filename2)
assert successful?
@api.delete_object(escaped_filename2)
assert successful?
delete_all_manifest_versions
end
def test_case_insensitivity
filename = @api.randomize_filename('casesensitive.PNG')
different_case_filename = filename.gsub(/PNG$/, 'png')
delete_all_file_versions(filename, different_case_filename)
delete_all_manifest_versions
post_file_data(@api, filename, 'stub-contents', 'application/png')
assert successful?
@api.get_object(filename)
assert successful?
@api.get_object(different_case_filename)
assert successful?
@api.delete_object(different_case_filename)
assert successful?
delete_all_manifest_versions
end
def test_nonexistent_file
filename = @api.randomize_filename('nonexistent.png')
dog_image_filename = @api.randomize_filename('dog.png')
delete_all_file_versions(filename, dog_image_filename)
delete_all_manifest_versions
# Check for file when no manifest is present:
@api.get_object(filename)
assert not_found?
dog_image_body = 'stub-dog-contents'
post_file_data(@api, dog_image_filename, dog_image_body, 'image/png')
assert successful?
# Check again for file when another file is now present:
@api.get_object(filename)
assert not_found?
@api.delete_object(dog_image_filename)
assert successful?
delete_all_manifest_versions
end
def test_file_versions
filename = @api.randomize_filename('test.png')
delete_all_file_versions(filename)
delete_all_manifest_versions
# Create an animation file
v1_file_data = 'stub-v1-body'
post_file_data(@api, filename, v1_file_data, 'image/png')
assert successful?
# Overwrite it.
v2_file_data = 'stub-v2-body'
post_file_data(@api, filename, v2_file_data, 'image/png')
assert successful?
# Delete it.
@api.delete_object(filename)
assert successful?
# List versions.
versions = @api.list_object_versions(filename)
assert successful?
assert_equal 2, versions.count
# Get the first and second version.
assert_equal v1_file_data, @api.get_object_version(filename, versions[1]['versionId'])
assert_equal v2_file_data, @api.get_object_version(filename, versions[0]['versionId'])
# Check cache headers
assert_match 'private, must-revalidate, max-age=0', last_response['Cache-Control']
# List project versions.
project_versions = @api.list_files_versions
assert successful?
assert_equal 3, project_versions.count
assert project_versions[0]['isLatest']
refute project_versions[1]['isLatest']
refute project_versions[2]['isLatest']
# Restore previous version
@api.restore_files_version(project_versions[2]['versionId'])
assert successful?
assert_equal v1_file_data, @api.get_object(filename)
# Delete it.
@api.delete_object(filename)
assert successful?
delete_all_manifest_versions
end
def test_invalid_file_extension
@api.get_object('bad_extension.css%22')
assert unsupported_media_type?
end
def test_bad_channel_id
bad_channel_id = 'undefined'
api = FilesApiTestHelper.new(current_session, 'files', bad_channel_id)
file_infos = api.list_objects
assert_equal '', file_infos['filesVersionId']
assert_equal [], file_infos['files']
end
def test_thumbnail
thumbnail_filename = '.metadata/thumbnail.png'
thumbnail_body = 'stub-dog-contents'
@api.get_object(thumbnail_filename)
assert not_found?
@api.put_object(thumbnail_filename, thumbnail_body)
assert successful?
assert_equal thumbnail_body, @api.get_object(thumbnail_filename)
@api.delete_object(thumbnail_filename)
assert successful?
@api.get_object(thumbnail_filename)
assert not_found?
end
def test_metadata_auth
thumbnail_filename = '.metadata/thumbnail.png'
thumbnail_body = 'stub-thumbnail-contents'
other_body = 'stub-other-contents'
@api.get_object(thumbnail_filename)
assert not_found?
@api.put_object(thumbnail_filename, thumbnail_body)
assert successful?
with_session(:non_owner) do
non_owner_api = FilesApiTestHelper.new(current_session, 'files', @channel_id)
# non-owner can view
assert_equal thumbnail_body, non_owner_api.get_object(thumbnail_filename)
# non-owner cannot put
non_owner_api.put_object(thumbnail_filename, other_body)
refute successful?
# non-owner cannot delete
non_owner_api.delete_object(thumbnail_filename)
refute successful?
end
# file contents has not changed
assert_equal thumbnail_body, @api.get_object(thumbnail_filename)
@api.delete_object(thumbnail_filename)
assert successful?
@api.get_object(thumbnail_filename)
assert not_found?
end
def test_bogus_metadata
bogus_metadata_filename = '.metadata/bogus.png'
bogus_metadata_body = 'stub-bogus-metadata-contents'
@api.get_object(bogus_metadata_filename)
assert not_found?
@api.put_object(bogus_metadata_filename, bogus_metadata_body)
assert bad_request?
@api.get_object(bogus_metadata_filename)
assert not_found?
@api.delete_object(bogus_metadata_filename)
assert bad_request?
@api.get_object(bogus_metadata_filename)
assert not_found?
end
def test_metadata_cached
thumbnail_filename = '.metadata/thumbnail.png'
thumbnail_body = 'stub-thumbnail-contents'
@api.put_object(thumbnail_filename, thumbnail_body)
assert successful?
get "/v3/files-public/#{@channel_id}/#{thumbnail_filename}"
assert successful?
assert_equal 'public, max-age=3600, s-maxage=1800', last_response['Cache-Control']
end
def test_rename_mixed_case
filename = @api.randomize_filename('Mixed Case With Spaces.html')
escaped_filename = URI.escape(filename)
filename2 = @api.randomize_filename('Another Mixed Case Spaces Name.html')
escaped_filename2 = URI.escape(filename2)
delete_all_file_versions(filename, filename2)
delete_all_manifest_versions
post_file_data(@api, filename, 'stub-contents', 'test/html')
assert successful?
@api.get_object(escaped_filename)
assert successful?
assert_equal 'stub-contents', last_response.body
@api.rename_object(filename, escaped_filename2)
assert successful?
@api.get_object(escaped_filename2)
assert successful?
assert_equal 'stub-contents', last_response.body
@api.get_object(escaped_filename)
assert not_found?
@api.delete_object(escaped_filename2)
assert successful?
delete_all_manifest_versions
end
def test_rename_case_only
filename = @api.randomize_filename('Mixed Case With Spaces.png')
escaped_filename = URI.escape(filename)
filename2 = filename.sub 'Mixed Case', 'mixeD casE'
escaped_filename2 = URI.escape(filename2)
delete_all_file_versions filename, filename2
delete_all_manifest_versions
image_body = 'stub-image-contents'
post_file_data(@api, filename, image_body, 'image/png')
assert successful?
@api.get_object(escaped_filename)
assert successful?
assert_equal image_body, last_response.body
@api.get_object(escaped_filename2)
assert successful?
assert_equal image_body, last_response.body
get "v3/files/#{@channel_id}"
response_before_rename = JSON.parse(last_response.body)
# There should be only one file with filename, category, and size matching our expectations
expected_image_info = {'filename' => filename, 'category' => 'image', 'size' => image_body.length}
file_infos = response_before_rename['files']
assert_equal(1, file_infos.length)
assert_fileinfo_equal(expected_image_info, file_infos[0])
@api.rename_object(filename, escaped_filename2)
assert successful?
@api.get_object(escaped_filename)
assert successful?
assert_equal image_body, last_response.body
@api.get_object(escaped_filename2)
assert successful?
assert_equal image_body, last_response.body
get "v3/files/#{@channel_id}"
response_after_rename = JSON.parse(last_response.body)
# There should be only one file with the new filename, category, and size matching our expectations
expected_image_info_after_rename = {'filename' => filename2, 'category' => 'image', 'size' => image_body.length}
file_infos_after_rename = response_after_rename['files']
assert_equal(1, file_infos_after_rename.length)
assert_fileinfo_equal(expected_image_info_after_rename, file_infos_after_rename[0])
# The manifest version (filesVersionId) should be different, but the file version should be the same
refute_equal response_before_rename['filesVersionId'], response_after_rename['filesVersionId']
assert_equal file_infos[0]['versionId'], file_infos_after_rename[0]['versionId']
@api.delete_object(escaped_filename2)
assert successful?
delete_all_manifest_versions
end
def test_files_copy_all
# This test creates 2 channels
delete_all_files('files_test/1/2')
dest_channel_id = create_channel
src_api = FilesApiTestHelper.new(current_session, 'files', @channel_id)
dest_api = FilesApiTestHelper.new(current_session, 'files', dest_channel_id)
image_filename = @api.randomize_filename('Cat.jpg')
image_body = 'stub-image-contents'
sound_filename = @api.randomize_filename('Woof Woof.mp3')
sound_body = 'stub-sound-contents'
post_file_data(src_api, image_filename, image_body, 'image/jpeg')
post_file_data(src_api, sound_filename, sound_body, 'audio/mpeg')
src_api.patch_abuse(10)
expected_image_info = {'filename' => image_filename, 'category' => 'image', 'size' => image_body.length}
expected_sound_info = {'filename' => sound_filename, 'category' => 'audio', 'size' => sound_body.length}
copy_file_infos = JSON.parse(copy_all(@channel_id, dest_channel_id))
dest_file_infos = dest_api.list_objects["files"]
assert_fileinfo_equal(expected_image_info, copy_file_infos[0])
assert_fileinfo_equal(expected_sound_info, copy_file_infos[1])
assert_fileinfo_equal(expected_image_info, dest_file_infos[0])
assert_fileinfo_equal(expected_sound_info, dest_file_infos[1])
dest_api.get_object(URI.escape(image_filename))
assert successful?
assert_equal image_body, last_response.body
dest_api.get_object(URI.escape(sound_filename))
assert successful?
assert_equal sound_body, last_response.body
# abuse score didn't carry over
assert_equal 0, FileBucket.new.get_abuse_score(dest_channel_id, URI.escape(image_filename.downcase))
assert_equal 0, FileBucket.new.get_abuse_score(dest_channel_id, URI.escape(sound_filename.downcase))
src_api.delete_object(URI.escape(image_filename))
src_api.delete_object(URI.escape(sound_filename))
delete_all_manifest_versions
dest_api.delete_object(URI.escape(image_filename))
dest_api.delete_object(URI.escape(sound_filename))
delete_channel(dest_channel_id)
end
private
def delete_all_files(bucket)
delete_all_objects(CDO.files_s3_bucket, bucket)
end
def copy_all(src_channel_id, dest_channel_id)
FileBucket.new.copy_files(src_channel_id, dest_channel_id).to_json
end
def post_file(api, uploaded_file)
body = {files: [uploaded_file]}
headers = {'CONTENT_TYPE' => 'multipart/form-data'}
api.post_object '', body, headers
end
def post_file_data(api, filename, file_contents, content_type)
file = api.create_uploaded_file(filename, file_contents, content_type)
post_file(api, file)
end
def delete_all_file_versions(*filenames)
filenames.each do |filename|
delete_all_versions(CDO.files_s3_bucket, "files_test/1/1/#{filename}")
end
end
def delete_all_manifest_versions
delete_all_file_versions 'manifest.json'
end
end