Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty lines in expand code browser #362

Merged
merged 1 commit into from
May 3, 2023
Merged

Fix empty lines in expand code browser #362

merged 1 commit into from
May 3, 2023

Conversation

pomber
Copy link
Contributor

@pomber pomber commented May 3, 2023

Fix #361

@vercel
Copy link

vercel bot commented May 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chtest ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2023 7:21am
playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2023 7:21am

@github-actions
Copy link

github-actions bot commented May 3, 2023

📦 Next.js Bundle Analysis for bundle-test

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/just-code 33.51 KB 107.78 KB 30.79% (+/- <0.01%)
/scrollycoding-preview 36.61 KB 110.88 KB 31.68% (+/- <0.01%)
/spotlight 34.07 KB 108.34 KB 30.95% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@pomber pomber merged commit 60b05d7 into next May 3, 2023
5 checks passed
@pomber pomber deleted the expand-empty-lines branch May 3, 2023 07:27
@github-actions
Copy link

github-actions bot commented May 3, 2023

🚀 PR was released in v0.8.3 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with empty lines in Scrollycoding expanded view
1 participant