Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default domain to .local instead of .dev #206

Merged
merged 1 commit into from
Dec 17, 2017
Merged

Conversation

kgrz
Copy link
Contributor

@kgrz kgrz commented Dec 16, 2017

.dev domains are now official TLDs, and browsers are automatically
redirecting the websites to https via HSTS lists. This will add an
annoying warning page, not to mention clashes with actual domains.

.dev domains are now official TLDs, and browsers are automatically
redirecting the websites to `https` via HSTS lists. This will add an
annoying warning page, not to mention clashes with actual domains.
@kgrz
Copy link
Contributor Author

kgrz commented Dec 16, 2017

Should this be a minor gem bump or a patchlevel one? I don't see a case for major bump because there isn't any backwards incompatible change.

kgrz added a commit that referenced this pull request Dec 16, 2017
We changed the default TLD to `.local` instead of `.dev`.
@kgrz
Copy link
Contributor Author

kgrz commented Dec 16, 2017

Documentation update PR: #207

@gnufied
Copy link
Contributor

gnufied commented Dec 16, 2017

I think minor bump is fine

@iffyuva iffyuva merged commit 9534d57 into master Dec 17, 2017
@iffyuva iffyuva deleted the change-default-tld branch December 17, 2017 02:53
iffyuva added a commit that referenced this pull request Dec 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants