Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using MaterialIconView in clickable parent makes ripple lag #14

Closed
quentin-st opened this issue Aug 21, 2015 · 2 comments
Closed

Using MaterialIconView in clickable parent makes ripple lag #14

quentin-st opened this issue Aug 21, 2015 · 2 comments
Labels

Comments

@quentin-st
Copy link

When using MaterialIconView in a clickable parent (a ListView for example), the ripple effect happening when clicking the parent lags and seems to contain artifacts.

The ListView has only one element. Tried on a OnePlusOne with no application in the background (so lag isn't because of a heavy work happening in the background).

Using standard ImageView or ImageButton component works well.

quentin-st added a commit to quentin-st/Munin-for-Android that referenced this issue Aug 21, 2015
Bug detected: when using MaterialIconView in a clickable parent, the ripple animation lags.
Issue has been reported (code-mc/material-icon-lib#14), waiting for an answer.
@code-mc code-mc added the bug label Aug 21, 2015
@code-mc
Copy link
Owner

code-mc commented Oct 26, 2015

This might be due to a bug that is fixed as of 1.0.5. Please update your dependency and let me know if it improves the situation. (It did for me as far as I could tell)

And apologies for the very late update, I just stumbled upon the bug in question by myself. Still very surprised not a single soul has reported anything about it except for this semi relevant report.

@code-mc code-mc closed this as completed Oct 28, 2015
@quentin-st
Copy link
Author

Thank you for the fix! I'll test it as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants