Feature/expandable alertbox #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscarcarlstrom
commented
Feb 19, 2024
| > | ||
| <Close /> | ||
| </Button> | ||
| )} | ||
| {restChildren} | ||
| {isExpandable && ( |
There was a problem hiding this comment.
Bruker custom implementasjon (<details> støttes ikke godt nok av skjermlesere). Testet og evaluert med VoiceOver der denne implementasjonen kom bedre ut.
oscarcarlstrom
commented
Feb 19, 2024
| onClose, | ||
| isDismissable = false, // Assign default value to make cva variants apply correctly | ||
| isDismissed, | ||
| onDismiss, |
There was a problem hiding this comment.
Standardisert navngivningen på disse
This reverts commit 3bedd5e.
oscarcarlstrom
commented
Feb 20, 2024
oscarcarlstrom
commented
Feb 20, 2024
| @@ -23,6 +23,7 @@ | |||
| "dependencies": { | |||
| "@obosbbl/grunnmuren-icons-react": "workspace:^2.0.0-canary.1", | |||
| "@react-aria/utils": "^3.23.0", | |||
| "@types/node": "^20.11.19", | |||
There was a problem hiding this comment.
Lagt til @types/node for at TS skal kompilere ved bruk av process.env.NODE_ENV
alexanbj
approved these changes
Feb 22, 2024
so the consumers don't need to add it themselves (because the component uses useState)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.