Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use v 9.1.0 of pnpm #826

Merged
merged 1 commit into from
May 8, 2024
Merged

Use v 9.1.0 of pnpm #826

merged 1 commit into from
May 8, 2024

Conversation

oscarcarlstrom
Copy link
Contributor

Oppgraderer til pnpm v9.1.0

Copy link

changeset-bot bot commented May 7, 2024

⚠️ No Changeset found

Latest commit: c2396b7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@oscarcarlstrom oscarcarlstrom requested a review from a team May 7, 2024 13:48
Copy link

netlify bot commented May 7, 2024

Deploy Preview for obos-grunnmuren ready!

Name Link
🔨 Latest commit c2396b7
🔍 Latest deploy log https://app.netlify.com/sites/obos-grunnmuren/deploys/663a3133e2f9b100099b62a6
😎 Deploy Preview https://deploy-preview-826--obos-grunnmuren.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -46,7 +46,7 @@
"tailwindcss": "3.4.3",
"typescript": "5.4.5"
},
"packageManager": "pnpm@9.0.6",
"packageManager": "pnpm@9.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Er på telefonen nå, så ikke helt sikker. Men er det ikke noe greier vi kan sette i pnpm configen som sier at denne ikke er strict?

Eventuelt kan verdien i package.json endres til å ikke være strict? Om jeg er på versjon 9.1.0 eller 9.1.1 er ikke så interessant tenker jeg. Det viktigste er at man ikke bruker pnpm 8!

Copy link
Contributor Author

@oscarcarlstrom oscarcarlstrom May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ja, jeg var litt inne på samme tanke. Er litt slitsomt å måtte oppdatere den for hver enste minor og patch. Man kan vel ofte skrive ranges i package.json, men ser ikke ut som det støttes enda: nodejs/corepack#208 (markert som duplikat av nodejs/corepack#95, som fortsatt er åpen)

@oscarcarlstrom oscarcarlstrom merged commit 4247c70 into main May 8, 2024
5 checks passed
@oscarcarlstrom oscarcarlstrom deleted the upgrade/pnpm branch May 8, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants