fix(utils): prevent mixed summary when some audit changed only value

code-pushup · Mar 19, 2024 · 20673fd · 20673fd
1 parent d4668df
commit 20673fd
Showing 1 changed file with 3 additions and 10 deletions.
diff --git a/packages/utils/src/lib/reports/generate-md-reports-diff.ts b/packages/utils/src/lib/reports/generate-md-reports-diff.ts
@@ -268,22 +268,15 @@ function changesToDiffOutcomes(changes: Change[]): DiffOutcome[] {
 }
 
 function mergeDiffOutcomes(outcomes: DiffOutcome[]): DiffOutcome {
-  if (outcomes.length === 0) {
+  if (outcomes.every(outcome => outcome === 'unchanged')) {
     return 'unchanged';
   }
-  if (
-    outcomes.every(outcome => outcome === 'positive' || outcome === 'unchanged')
-  ) {
+  if (outcomes.includes('positive') && !outcomes.includes('negative')) {
     return 'positive';
   }
-  if (
-    outcomes.every(outcome => outcome === 'negative' || outcome === 'unchanged')
-  ) {
+  if (outcomes.includes('negative') && !outcomes.includes('positive')) {
     return 'negative';
   }
-  if (outcomes.every(outcome => outcome === 'unchanged')) {
-    return 'unchanged';
-  }
   return 'mixed';
 }