fix(plugin-eslint): dynamic import for optional peer dep @nx/devkit

code-pushup · Dec 4, 2023 · ab62f2f · ab62f2f
1 parent d6a6b2a
commit ab62f2f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/packages/plugin-eslint/src/lib/nx/find-all-projects.ts b/packages/plugin-eslint/src/lib/nx/find-all-projects.ts
@@ -1,4 +1,3 @@
-import { createProjectGraphAsync } from '@nx/devkit';
 import type { ESLintPluginConfig } from '../config';
 import { nxProjectsToConfig } from './projects-to-config';
 
@@ -24,6 +23,7 @@ import { nxProjectsToConfig } from './projects-to-config';
  * @returns ESLint config and patterns, intended to be passed to {@link eslintPlugin}
  */
 export async function eslintConfigFromNxProjects(): Promise<ESLintPluginConfig> {
+  const { createProjectGraphAsync } = await import('@nx/devkit');
   const projectGraph = await createProjectGraphAsync({ exitOnError: false });
   return nxProjectsToConfig(projectGraph);
 }
diff --git a/packages/plugin-eslint/src/lib/nx/find-project-with-deps.ts b/packages/plugin-eslint/src/lib/nx/find-project-with-deps.ts
@@ -1,4 +1,3 @@
-import { createProjectGraphAsync } from '@nx/devkit';
 import type { ESLintPluginConfig } from '../config';
 import { nxProjectsToConfig } from './projects-to-config';
 import { findAllDependencies } from './traverse-graph';
@@ -30,6 +29,7 @@ import { findAllDependencies } from './traverse-graph';
 export async function eslintConfigFromNxProject(
   projectName: string,
 ): Promise<ESLintPluginConfig> {
+  const { createProjectGraphAsync } = await import('@nx/devkit');
   const projectGraph = await createProjectGraphAsync({ exitOnError: false });
 
   const dependencies = findAllDependencies(projectName, projectGraph);

diff --git a/packages/plugin-eslint/src/lib/nx/projects-to-config.ts b/packages/plugin-eslint/src/lib/nx/projects-to-config.ts
@@ -1,8 +1,4 @@
-import {
-  ProjectConfiguration,
-  ProjectGraph,
-  readProjectsConfigurationFromProjectGraph,
-} from '@nx/devkit';
+import type { ProjectConfiguration, ProjectGraph } from '@nx/devkit';
 import type { ESLint } from 'eslint';
 import type { ESLintPluginConfig } from '../config';
 import {
@@ -16,6 +12,9 @@ export async function nxProjectsToConfig(
   predicate: (project: ProjectConfiguration) => boolean = () => true,
 ): Promise<ESLintPluginConfig> {
   // find Nx projects with lint target
+  const { readProjectsConfigurationFromProjectGraph } = await import(
+    '@nx/devkit'
+  );
   const projectsConfiguration =
     readProjectsConfigurationFromProjectGraph(projectGraph);
   const projects = Object.values(projectsConfiguration.projects)