Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch Git commit hash and message for reports #192

Closed
8 tasks
matejchalk opened this issue Nov 1, 2023 · 0 comments · Fixed by #205
Closed
8 tasks

Fetch Git commit hash and message for reports #192

matejchalk opened this issue Nov 1, 2023 · 0 comments · Fixed by #205
Assignees

Comments

@matejchalk
Copy link
Collaborator

matejchalk commented Nov 1, 2023

Needed for:

Currently, we only fetch the commit hash, and only for upload. We also need it for formatting reports, where we need the commit message as well for readability.

  • replace latestHash function with getLatestCommit which returns other metadata as well as an object
    • sha
    • message
    • author
    • date
  • call getLatestCommit function before creating markdown report, pass as parameter to reportToMd function
  • for collect: if commit not found (e.g. not run in Git repo), log warning but don't exit - report.md will display commit is unknown
  • for upload: if commit not found, throw an error - we can't upload correctly without it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants