Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): introduce the onlyPlugins option #246

Merged
merged 4 commits into from
Nov 16, 2023
Merged

feat(cli): introduce the onlyPlugins option #246

merged 4 commits into from
Nov 16, 2023

Conversation

IKatsuba
Copy link
Contributor

Close #119

I modified configMiddleware and filtered all plugins. This allowed us not to modify the commands.

BioPhoton
BioPhoton requested changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a small comment. As the options does not apply for all commands e.g. upload we should put the type and options in the specific command.

packages/models/src/lib/global-options.ts Outdated Show resolved Hide resolved
BioPhoton
BioPhoton reviewed Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one question on where to put the CLI option schema.. but no good answer. :D
Looks good otherwise!!
🎉🎉🎉

packages/models/src/lib/only-plugins-options.ts Outdated Show resolved Hide resolved
@BioPhoton BioPhoton added 🤓 UX UX improvement for CLI users 🧩 cli labels Nov 13, 2023
matejchalk
matejchalk requested changes Nov 14, 2023
View reviewed changes
e2e/cli-e2e/tests/print-config.spec.ts Outdated Show resolved Hide resolved
packages/cli/src/lib/implementation/config-middleware.ts Outdated Show resolved Hide resolved
packages/cli/src/lib/implementation/config-middleware.ts Outdated Show resolved Hide resolved
packages/models/src/lib/only-plugins-options.ts Outdated Show resolved Hide resolved
BioPhoton
BioPhoton requested changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@BioPhoton BioPhoton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally this package should only impact the cli package and is not reflected in core or models.

I opened #258 to make the scope here smaller. Added you as reviewer.

@BioPhoton BioPhoton mentioned this pull request Nov 15, 2023
Merged
@BioPhoton
Copy link
Collaborator

@IKatsuba

PR closed please merge

@IKatsuba IKatsuba force-pushed the only-plugins-option branch 3 times, most recently from ca4fa8c to c7c614c Compare November 15, 2023 21:15
@IKatsuba
Copy link
Contributor Author

Ideally this package should only impact the cli package and is not reflected in core or models.

@BioPhoton I did it!

BioPhoton
BioPhoton approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

BioPhoton
BioPhoton previously approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@BioPhoton BioPhoton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the changes

@IKatsuba IKatsuba marked this pull request as ready for review November 16, 2023 19:47
BioPhoton
BioPhoton previously approved these changes Nov 16, 2023
View reviewed changes
@IKatsuba IKatsuba enabled auto-merge (squash) November 16, 2023 20:21
@IKatsuba @matejchalk
chore(cli): apply suggestion
540ae48 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@IKatsuba @matejchalk
chore(cli): apply suggestion
d6d91e0 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@IKatsuba IKatsuba merged commit 13c9d26 into main Nov 16, 2023
11 checks passed
@IKatsuba IKatsuba deleted the only-plugins-option branch November 16, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejchalk matejchalk matejchalk approved these changes

@BioPhoton BioPhoton Awaiting requested review from BioPhoton

Assignees

@IKatsuba IKatsuba

Labels
🧩 cli 🤓 UX UX improvement for CLI users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add argument onlyPlugins for commands autorun, print-config and collect
3 participants
@IKatsuba @BioPhoton @matejchalk