-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): introduce the onlyPlugins
option
#246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a small comment. As the options does not apply for all commands e.g. upload
we should put the type and options in the specific command.
7437190
to
28b135a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one question on where to put the CLI option schema.. but no good answer. :D
Looks good otherwise!!
🎉🎉🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally this package should only impact the cli
package and is not reflected in core
or models
.
I opened #258 to make the scope here smaller. Added you as reviewer.
PR closed please merge |
ca4fa8c
to
c7c614c
Compare
@BioPhoton I did it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for the changes
f1677c7
to
c177aa8
Compare
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Close #119
I modified
configMiddleware
and filtered all plugins. This allowed us not to modify the commands.