Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistency in formats #316

Closed
Tracked by #322
BioPhoton opened this issue Nov 24, 2023 · 0 comments · Fixed by #360
Closed
Tracked by #322

inconsistency in formats #316

BioPhoton opened this issue Nov 24, 2023 · 0 comments · Fixed by #360
Assignees
Labels
🐛 bug something isn't working 🧩 core

Comments

@BioPhoton
Copy link
Collaborator

BioPhoton commented Nov 24, 2023

Wanted behaviour

The following behaviour is only relevant for the collect, print-config and autorun command.

The following pieces are involved:

Each layer can overwrite the previose one.

flowchart TB;

   Terminal-->CLI-Argument-Parsing;
   CLI-Argument-Parsing-->Load-Rc-Config;
   Load-Rc-Config-->Command-Argument-Parsing;
   Command-Argument-Parsing-->Command-Execution;

   click CLI-Argument-Parsing "./" "view source"

Loading

docs for the diagram

Model

The model will default the format value of to 'json'.

print-config and collect command

We will respect the user input. This is save as there is no upload done.

Cases:

  • undefined in RC -> json
  • md,json in RC -> md,json
  • md,json in RC, md in terminal -> md

autorun command

We always add json to the configured formats as the JSON version is needed for the upload

Cases:

  • undefined in RC -> json
  • md,json in RC -> md,json
  • md,json in RC, md in terminal -> md,json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug something isn't working 🧩 core
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant