Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-lighthouse): implement basic audit parsing #523

Merged
merged 14 commits into from
Feb 29, 2024

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Feb 24, 2024

This PR includes:

  • logic to parse LH audits to CP audits
  • tests
  • test data for all unimplemented details

Supported detail types:

Further considerations:
As many of the lighthouse audits have hard to parse details we should discuss #293 again.

partially resolves #90

Copy link

nx-cloud bot commented Feb 24, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 92e915c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 9 targets

Sent with 💌 from NxCloud.

@BioPhoton BioPhoton marked this pull request as ready for review February 24, 2024 10:06
Copy link
Collaborator

@Tlacenka Tlacenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice small increment!

A few minor suggestions below.

It would really help me to see the Lighthouse plugin criteria for additional context.
If you plan on working on the official plugin more, could we go through the epic on a refinement?

packages/plugin-lighthouse/src/lib/utils.unit.test.ts Outdated Show resolved Hide resolved
packages/plugin-lighthouse/src/lib/utils.unit.test.ts Outdated Show resolved Hide resolved
packages/plugin-lighthouse/src/lib/utils.unit.test.ts Outdated Show resolved Hide resolved
packages/plugin-lighthouse/src/lib/utils.ts Outdated Show resolved Hide resolved
Co-authored-by: Katka Pilátová <katerina.pilatova@flowup.cz>
packages/plugin-lighthouse/src/lib/utils.ts Outdated Show resolved Hide resolved
packages/plugin-lighthouse/src/lib/utils.ts Outdated Show resolved Hide resolved
packages/plugin-lighthouse/src/lib/utils.ts Show resolved Hide resolved
packages/plugin-lighthouse/src/lib/utils.ts Outdated Show resolved Hide resolved
packages/plugin-lighthouse/src/lib/utils.unit.test.ts Outdated Show resolved Hide resolved
packages/plugin-lighthouse/src/lib/utils.unit.test.ts Outdated Show resolved Hide resolved
@BioPhoton
Copy link
Collaborator Author

BioPhoton commented Feb 28, 2024

@Tlacenka

could we go through the epic on a refinement?

Yes, but I assume a quick sync between us is good for now.

In the meantime I added more description to the plugin issue #90

matejchalk
matejchalk previously approved these changes Feb 29, 2024
matejchalk
matejchalk previously approved these changes Feb 29, 2024
@BioPhoton BioPhoton merged commit cbd044e into main Feb 29, 2024
19 checks passed
@BioPhoton BioPhoton deleted the plugin-lighthouse-runner branch February 29, 2024 14:39
@BioPhoton BioPhoton restored the plugin-lighthouse-runner branch March 25, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Lighthouse plugin
3 participants