-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin-lighthouse): implement basic audit parsing #523
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 92e915c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 9 targets
Sent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice small increment!
A few minor suggestions below.
It would really help me to see the Lighthouse plugin criteria for additional context.
If you plan on working on the official plugin more, could we go through the epic on a refinement?
Co-authored-by: Katka Pilátová <katerina.pilatova@flowup.cz>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Katka Pilátová <katerina.pilatova@flowup.cz>
This PR includes:
Supported detail types:
Further considerations:
As many of the lighthouse audits have hard to parse details we should discuss #293 again.
partially resolves #90